UI: List host OOBM details when enabled and configured#10472
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10472 +/- ##
=========================================
Coverage 15.16% 15.17%
- Complexity 11327 11329 +2
=========================================
Files 5413 5413
Lines 474778 474778
Branches 57905 57905
=========================================
+ Hits 72007 72024 +17
+ Misses 394721 394702 -19
- Partials 8050 8052 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
clgtm and works in qa:
however, I would expect the dialog to be filled with those values as well when re-configuring. (not sure if this would be another feature.
That does make sense @DaanHoogland . This is the legacy way it behaves. I think it would be a enhancement, as we'd need to define a component for it. |
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
clgtm and works in qa:
however, I would expect the dialog to be filled with those values as well when re-configuring. (not sure if this would be another feature.
Yes, when reconfiguring the oobm details, i would also like the details to be pre-populated like edit host
|
Can this be addressed in a separate PR @kiranchavala . |
|
Added username as well: |
|
@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
bernardodemarco
left a comment
bernardodemarco
left a comment
There was a problem hiding this comment.
lgtm, verified that the OOBM details are displayed in the host details page:
|
@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
Comment addressed |
|
* UI: List host OOBM details when enabled and configured * Add username details * address comment
5 participants
Description
This PR fixes: #10194
Adds the OOBM details when configured and is enabled.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?